[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI sche
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files |
Date: |
Tue, 6 May 2014 12:55:27 -0400 |
On Tue, 06 May 2014 08:55:52 -0600
Eric Blake <address@hidden> wrote:
> > Eventually, we might want to have if/defs and whatnot. But having a master
> > file seems a reasonable first step to me. I actually thought this was the
> > intention. Unless I got it wrong, of course.
>
> Ifdefs may be a bit much. If we add them, then we can worry about
> explicit include guards, the same as the C preprocessor. But for now,
> I'd be perfectly fine with a followup patch that includes a file's
> contents exactly once, no matter how many times it is included (that is,
> act as if include guards were implicitly present, since we lack
> conditionals, so include files are currently idempotent).
OK. Does it make sense to merge the current series without that
modification?
- Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files, (continued)
Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files, Benoît Canet, 2014/05/06
Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files, Eric Blake, 2014/05/06