Re: [Qemu-devel] [PATCH 1/4] curl: Fix parsing of readahead option from filename

[Matthew Booth]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 13/05/14 13:29, Eric Blake wrote:
> On 05/08/2014 02:42 AM, Matthew Booth wrote:
>> curl_parse_filename wasn't removing the option string from the
>> url, resulting in a 404.
>> 
>> This change is a rewrite of the previous parsing behaviour, and 
>> also changes the option syntax. The new syntax is:
>> 
>> http://example.com/path?query[sslverify=off:readahead=64k]
> 
> Again, I'm not sure I'm happy with this - we shouldn't be inventing
> our own syntax when URI is already a well-defined syntax.

I don't understand. Are you suggesting adding the options as query
parameters to the URI? We obviously can't do that, because it would
change the URI. Neither can we assume that the URI will not contain
query parameters and we have them to ourselves. For example, vsphere
disk URIs, which is what I'm targetting, contain query parameters.

Matt

> 
>> 
>> The new syntax is well defined as long as square brackets in the
>> URI are escaped.
>> 
>> This change is also preparation for the addition of more
>> options.
>> 
>> Signed-off-by: Matthew Booth <address@hidden> --- block/curl.c
>> | 101
>> +++++++++++++++++++++++++++++++++++++++-------------------- 1
>> file changed, 67 insertions(+), 34 deletions(-)
>> 
> 


- -- 
Matthew Booth
Red Hat Engineering, Virtualisation Team

Phone: +442070094448 (UK)
GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlNzkyAACgkQNEHqGdM8NJAdggCfXzCS0LtG+kzq5TT/ldcCX6tr
o+oAniBxwg/7yw6w8PVw6SSXtBXt4zz0
=tuPB
-----END PGP SIGNATURE-----