[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] numa: Reject duplicate node IDs
From: |
Hu Tao |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] numa: Reject duplicate node IDs |
Date: |
Fri, 27 Jun 2014 11:30:07 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Jun 26, 2014 at 06:33:19PM -0300, Eduardo Habkost wrote:
> The same nodeid shouldn't appear multiple times in the command-line.
>
> In addition to detecting command-line mistakes, this will fix a bug
> where nb_numa_nodes may become larger than MAX_NODES (and cause
> out-of-bounds access on the numa_info array).
>
> Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Hu Tao <address@hidden>
This patch makes me remembering the same problem for cpus, like -numa
..cpus=1,.. -numa ..cpus=1,.., in the case one node has cpu, the other
doesn't. Maybe we should eject it too.
> ---
> numa.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/numa.c b/numa.c
> index 3de9116..e93407a 100644
> --- a/numa.c
> +++ b/numa.c
> @@ -62,6 +62,11 @@ static void numa_node_parse(NumaNodeOptions *node,
> QemuOpts *opts, Error **errp)
> return;
> }
>
> + if (numa_info[nodenr].present) {
> + error_setg(errp, "Duplicate NUMA nodeid: %" PRIu16, nodenr);
> + return;
> + }
> +
> for (cpus = node->cpus; cpus; cpus = cpus->next) {
> if (cpus->value > MAX_CPUMASK_BITS) {
> error_setg(errp, "CPU number %" PRIu16 " is bigger than %d",
> --
> 1.9.3
- [Qemu-devel] [PATCH 0/3] Validate NUMA node IDs (reject duplicate/missing node IDs properly), Eduardo Habkost, 2014/06/26
- [Qemu-devel] [PATCH 2/3] numa: Reject duplicate node IDs, Eduardo Habkost, 2014/06/26
- Re: [Qemu-devel] [PATCH 2/3] numa: Reject duplicate node IDs,
Hu Tao <=
- [Qemu-devel] [PATCH 1/3] numa: Keep track of NUMA nodes present on the command-line, Eduardo Habkost, 2014/06/26
- [Qemu-devel] [PATCH 3/3] numa: Reject configuration if not all node IDs are present, Eduardo Habkost, 2014/06/26
- Re: [Qemu-devel] [PATCH for 2.1 0/3] Validate NUMA node IDs (reject duplicate/missing node IDs properly), Eric Blake, 2014/06/26
- Re: [Qemu-devel] [PATCH 0/3] Validate NUMA node IDs (reject duplicate/missing node IDs properly), Michael S. Tsirkin, 2014/06/29