[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] qcow2: Fix leak of QemuOpts in qcow2_open()
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] qcow2: Fix leak of QemuOpts in qcow2_open() |
Date: |
Thu, 21 Aug 2014 19:54:04 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
The Wednesday 20 Aug 2014 à 19:59:33 (+0200), Max Reitz wrote :
> Currently, the QemuOpts object opts is leaked if anything fails from its
> creation up to and including the image repair block. Fix this by freeing
> that object in the fail path.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/qcow2.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/block/qcow2.c b/block/qcow2.c
> index f9e045f..c64d611 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -535,7 +535,7 @@ static int qcow2_open(BlockDriverState *bs, QDict
> *options, int flags,
> unsigned int len, i;
> int ret = 0;
> QCowHeader header;
> - QemuOpts *opts;
> + QemuOpts *opts = NULL;
> Error *local_err = NULL;
> uint64_t ext_end;
> uint64_t l1_vm_state_index;
> @@ -932,7 +932,6 @@ static int qcow2_open(BlockDriverState *bs, QDict
> *options, int flags,
> error_setg(errp, "Unsupported value '%s' for qcow2 option "
> "'overlap-check'. Allowed are either of the following: "
> "none, constant, cached, all", opt_overlap_check);
> - qemu_opts_del(opts);
> ret = -EINVAL;
> goto fail;
> }
> @@ -947,6 +946,7 @@ static int qcow2_open(BlockDriverState *bs, QDict
> *options, int flags,
> }
>
> qemu_opts_del(opts);
> + opts = NULL;
>
> if (s->use_lazy_refcounts && s->qcow_version < 3) {
> error_setg(errp, "Lazy refcounts require a qcow2 image with at least
> "
> @@ -964,6 +964,7 @@ static int qcow2_open(BlockDriverState *bs, QDict
> *options, int flags,
> return ret;
>
> fail:
> + qemu_opts_del(opts);
> g_free(s->unknown_header_fields);
> cleanup_unknown_header_ext(bs);
> qcow2_free_snapshots(bs);
> --
> 2.0.4
>
>
Reviewed-by: Benoît Canet <address@hidden>