Re: [Qemu-devel] [PATCH v5 10/15] target-tricore: Add instructions of SB opcode format

[Richard Henderson]

On 08/13/2014 05:07 AM, Bastian Koppelmann wrote:
> @@ -679,9 +768,11 @@ gen_intermediate_code_internal(TRICORECPU *cpu, struct 
> TranslationBlock *tb,
>          num_insns++;
>  
>          if (tcg_ctx.gen_opc_ptr >= gen_opc_end) {
> +            gen_goto_tb(&ctx, 0, ctx.next_pc);
>              break;
>          }
>          if (singlestep) {
> +            gen_goto_tb(&ctx, 0, ctx.next_pc);
>              break;
>          }

Do not use goto_tb under singlestep.  That can make it very hard to debug
translator bugs.  I've been considering checking for that at the tcg level,
except that almost all translators have this bug.


r~