Re: [Qemu-devel] [PATCH] curl: Add override_accept_ranges flag to force sending range requests.

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 08/26/2014 08:38 PM, Fam Zheng wrote:
>> On Tue, 08/26 21:48, Richard W.M. Jones wrote:
>>> Some servers (notably VMware ESX) accept range requests, but don't
>>> send back the Accept-Ranges: bytes header in their initial response.
>>>
>>> For these servers you can set override_accept_ranges to 'on' which
>>> forces this block driver to send range requests anyway.
>
> Is this a case where we should be naming with dashes instead of
> underscores, as in override-accept-ranges?

Yes.

>>> @@ -489,6 +490,11 @@ static QemuOptsList runtime_opts = {
>>>              .type = QEMU_OPT_BOOL,
>>>              .help = "Verify SSL certificate"
>>>          },
>>> +        {
>>> +            .name = CURL_BLOCK_OPT_OVERRIDE_ACCEPT_RANGES,
>>> +            .type = QEMU_OPT_BOOL,
>>> +            .help = "Server accepts range requests"
>>> +        },
>
> It would be nice for someone to finally port the QAPI counterpart
> (BlockdevOptions) so that curl devices can be hotplugged via
> blockdev-add.  But I guess that's a separate patch.

Yes again.