[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 13/14] ppc: inline ppc_set_crf when clearer
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 13/14] ppc: inline ppc_set_crf when clearer |
|
Date: |
Fri, 19 Sep 2014 15:51:14 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
Il 18/09/2014 22:33, Tom Musta ha scritto:
>> > Do not go through the loop when we're setting the four CR fields to
>> > separate constants or conditions. This is clearer than putting together
>> > 4-bit value and passing it.
> I guess "clearer" is in the eye of the beholder .... :)
>
> In general, replacing a single line of code with four is not a simplification
> (IMO).
>
> That said, I was not able to spot or identify by testing any functional
> problems with this patch.
>
True. It is better to say that it avoids messing with bit endianness.
Paolo
- Re: [Qemu-devel] [PATCH 09/14] ppc: introduce ppc_get_crf and ppc_set_crf, (continued)
- [Qemu-devel] [PATCH 10/14] ppc: use movcond for isel, Paolo Bonzini, 2014/09/15
- [Qemu-devel] [PATCH 11/14] ppc: store CR registers in 32 1-bit registers, Paolo Bonzini, 2014/09/15
- [Qemu-devel] [PATCH 12/14] ppc: use movcond to implement evsel, Paolo Bonzini, 2014/09/15
- [Qemu-devel] [PATCH 13/14] ppc: inline ppc_set_crf when clearer, Paolo Bonzini, 2014/09/15
- [Qemu-devel] [PATCH 14/14] ppc: dump all 32 CR bits, Paolo Bonzini, 2014/09/15
- Re: [Qemu-devel] [PATCH v2 00/14] TCG ppc speedups, Tom Musta, 2014/09/18