Re: [Qemu-devel] [PATCH 00/15] AHCI test helper refactors

[John Snow]

On 09/19/2014 06:53 AM, Markus Armbruster wrote:
> John Snow <address@hidden> writes:
>
> > The original version of the AHCI test base
> > which is now staged for being merged, processes
> > the ahci_identify test in a monolithic fashion.
> >
> > In authoring new tests, it became necessary and
> > obvious as to how the operation of this device
> > should be factored out to ease the writing of
> > new AHCI tests.
> >
> > This patch set issues the necessary refactorings
> > to support future test development for AHCI.
> >
> > This patch set DOES NOT account for any new fixes
> > and requires no fixes from my "AHCI fixes" RFC
> > in order to run successfully on 2014-09-18's
> > origin/master.
> >
> > This patch set does not alter the operation of the
> > existing test, or add new tests. It only offers
> > refactorings for future patch submissions which
> > depend on them, but are still under consideration.
> [...]
> >   tests/ahci-test.c | 860 ++++++++++++++++++++++++++++++++++++------------------
> >   1 file changed, 583 insertions(+), 277 deletions(-)
>
> Ignorant question: why should we commit the "monolithic" test only to
> refactor it extensively right away?

Newbie problems, basically.

I submitted the first AHCI test series 2014-07-07. The tests were staged 
last week. A lot happened on my downstream copy in that time, but I 
opted to keep the series "the same scope" from v1 through v4, because 
otherwise the series would have just kept growing ... I submitted v4

I do apologize at how absurd it is, on your end, to see an introduction 
followed immediately by a refactor. It seemed like the idea at the time 
was to get a basis that people agreed upon, then modify as needed.

Sorry for the confusion.

--
—js