Re: [Qemu-devel] [PATCH v2 0/4] Add TriCore RCPW, RCRR, RCRW, RLC and RCR instructions

[Richard Henderson]

On 11/13/2014 06:12 PM, Bastian Koppelmann wrote:
> Hi,
> 
> this patch depends on the previous TriCore patches 
> (https://patchwork.ozlabs.org/patch/405459/) and will hopefully end up in 2.3 
> QEMU.
> Other than adding the RCPW, RCRR, RCRW, RLC and RCR instructions, it cleans 
> up how ISA versions in the feature bitmask are handled,
> to simplify the checks, when instructions are available.
> 
> Thanks,
> Bastian
> 
> v1 -> v2:
>     - Fixed obvious style errors, given by checkpatch.
> 
> Bastian Koppelmann (4):
>   target-tricore: Make TRICORE_FEATURES implying others.
>   target-tricore: Add instructions of RCPW, RCRR and RCRW opcode format
>   target-tricore: Add instructions of RLC opcode format
>   target-tricore: Add instructions of RCR opcode format

Patches 1-3 get

Reviewed-by: Richard Henderson <address@hidden>

Patch 4 looks correct, but appears to work too hard.


r~