Re: [Qemu-devel] [PATCH RFC v5 05/19] virtio: support more feature bits

[Cornelia Huck]

On Tue,  2 Dec 2014 14:00:13 +0100
Cornelia Huck <address@hidden> wrote:


> diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
> index 070006c..23d713b 100644
> --- a/include/hw/qdev-properties.h
> +++ b/include/hw/qdev-properties.h
> @@ -51,6 +51,17 @@ extern PropertyInfo qdev_prop_arraylen;
>          .defval    = (bool)_defval,                              \
>          }
> 
> +#define DEFINE_PROP_BIT64(_name, _state, _field, _bit, _defval) {  \
> +        .name      = (_name),                                    \
> +        .info      = &(qdev_prop_bit),                           \
> +        .bitnr    = (_bit),                                      \
> +        .offset    = offsetof(_state, _field)                    \
> +            + type_check(uint64_t,typeof_field(_state, _field)), \
> +        .qtype     = QTYPE_QBOOL,                                \
> +        .defval    = (bool)_defval,                              \
> +        }
> +
> +
>  #define DEFINE_PROP_BOOL(_name, _state, _field, _defval) {       \
>          .name      = (_name),                                    \
>          .info      = &(qdev_prop_bool),                          \

This one is of course broken. I'll send an updated patch tomorrow.