Re: [Qemu-devel] [PATCH v3 6/7] hw/arm: pass pristine kernel image to guest firmware over fw_cfg

[Peter Maydell]

On 12 December 2014 at 13:52, Laszlo Ersek <address@hidden> wrote:
> On 12/12/14 14:20, Peter Maydell wrote:
>> If we have a real bootloader in the UEFI firmware, why do we need
>> to do decompression for it? We only do this in the builtin bootloader
>> because QEMU is acting as the bootloader and has to support the
>> feature itself. I would have thought that the UEFI builtin kernel
>> booting support already supported decompressing the kernel...
>
> The "UEFI builtin kernel booting support" will qualify as "builtin" only
> after my 2500 line patch series is merged in edk2.

I had in mind the support for UEFI loading kernels off
hard disks, which presumably is already present.

> Zlib decompression is not present in edk2 (it only has a TianoCore
> variant of LZMA), and I didn't want to impede (in the community sense)
> my edk2 patchset even more (ie. beyond its current size) by importing
> libz too.

Fair enough. This avoids odd inconsistency in compressed kernel
support between the f/w and non f/w setups, anyway.

If you fix the stray space then
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM