Re: [Qemu-devel] [PATCH v3 5/7] hw/loader: split out load_image_gzipped_buffer()

[Peter Maydell]

On 9 December 2014 at 01:13, Laszlo Ersek <address@hidden> wrote:
> In the next patch we'd like to reuse the image decompression facility
> without installing the output as a ROM at a specific guest-phys address.
>
> In addition, expose LOAD_IMAGE_MAX_GUNZIP_BYTES, because that's a
> straightforward "max_sz" argument for the new load_image_gzipped_buffer().
>
> Signed-off-by: Laszlo Ersek <address@hidden>
> ---

> +int load_image_gzipped(const char *filename, hwaddr addr, uint64_t max_sz)
> +{
> +    int bytes;
> +    uint8_t *data;
> +
> +    bytes = load_image_gzipped_buffer (filename, max_sz, &data);

Doesn't checkpatch complain about the space before the "(" here?

Otherwise:
Reviewed-by: Peter Maydell <address@hidden>

-- PMM