[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Did we lose monitor commands pci_add, pci_del?
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] Did we lose monitor commands pci_add, pci_del? |
Date: |
Sat, 14 Feb 2015 09:54:21 +1100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Feb 13, 2015 at 05:51:26PM +0100, Markus Armbruster wrote:
> Commit 79ca616 "pci: Cleanup configuration for pci-hotplug.c" (June
> 2013, released in v1.6.0) made linking pci-hotplug-old.o conditional on
> make variable CONFIG_PCI_HOTPLUG_OLD, and the actual monitor commands
> conditional on preprocessor macro CONFIG_PCI_HOTPLUG_OLD. Where is that
> macro defined?
>
> In my local build: nowhere. The two commands are not available.
>
> Am I doing something wrong, or have the commands been gone for five
> major releases already?
>
> If the latter, I think we can safely drop them now :)
So AFAICT, CONFIG_PCI_HOTPLUG_OLD is still defined for x86 targets:
$ git grep PCI_HOTPLUG_OLD
default-configs/i386-softmmu.mak:CONFIG_PCI_HOTPLUG_OLD=y
default-configs/x86_64-softmmu.mak:CONFIG_PCI_HOTPLUG_OLD=y
...
I believe the reasoning was that for other targets, pci_add/del were
never properly supported and we should go directly to device_add/del
instead.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgpxgJQPU5Vtj.pgp
Description: PGP signature
- [Qemu-devel] Did we lose monitor commands pci_add, pci_del?, Markus Armbruster, 2015/02/13
- Re: [Qemu-devel] Did we lose monitor commands pci_add, pci_del?,
David Gibson <=
- Re: [Qemu-devel] Did we lose monitor commands pci_add, pci_del?, Paolo Bonzini, 2015/02/14
- Re: [Qemu-devel] Did we lose monitor commands pci_add, pci_del?, David Gibson, 2015/02/14
- Re: [Qemu-devel] Did we lose monitor commands pci_add, pci_del?, Peter Maydell, 2015/02/15
- Re: [Qemu-devel] Did we lose monitor commands pci_add, pci_del?, Markus Armbruster, 2015/02/16
- Re: [Qemu-devel] Did we lose monitor commands pci_add, pci_del?, Michael Tokarev, 2015/02/16
- Re: [Qemu-devel] Did we lose monitor commands pci_add, pci_del?, Paolo Bonzini, 2015/02/16