[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/6] rename save_block_hdr to save_page_header
|
From: |
Li, Liang Z |
|
Subject: |
Re: [Qemu-devel] [PATCH 6/6] rename save_block_hdr to save_page_header |
|
Date: |
Thu, 26 Feb 2015 04:53:47 +0000 |
> On (Thu) 12 Feb 2015 [23:03:11], Juan Quintela wrote:
> > It has always been a page header, not a block header. Once there, the
> > flag argument was only passed to make a bit or with it, just do the or
> > on the caller.
>
> I prefer not to do that -- if one looks at the function signature, he'll only
> notice 'offset' there and not 'offset|flag', so it's confusing to callers of
> function why the | is being done for an offset field.
>
> Let's keep that bit as-is?
>
Same opinion.
Liang
- [Qemu-devel] [PATCH 0/6] migration: differentiate between pages and bytes, Juan Quintela, 2015/02/12
- [Qemu-devel] [PATCH 1/6] ram: make all save_page functions take a uint64_t parameter, Juan Quintela, 2015/02/12
- [Qemu-devel] [PATCH 2/6] ram_find_and_save_block: change calling convention, Juan Quintela, 2015/02/12
- [Qemu-devel] [PATCH 5/6] save_block_hdr: we can recalculate the cont parameter here, Juan Quintela, 2015/02/12
- [Qemu-devel] [PATCH 6/6] rename save_block_hdr to save_page_header, Juan Quintela, 2015/02/12
- [Qemu-devel] [PATCH 3/6] ram_save_page: change calling covention, Juan Quintela, 2015/02/12
- [Qemu-devel] [PATCH 4/6] save_xbzrle_page: change calling convention, Juan Quintela, 2015/02/12
- Re: [Qemu-devel] [PATCH 0/6] migration: differentiate between pages and bytes, Li, Liang Z, 2015/02/12
- Re: [Qemu-devel] [PATCH 0/6] migration: differentiate between pages and bytes, Dr. David Alan Gilbert, 2015/02/17
- Re: [Qemu-devel] [PATCH 0/6] migration: differentiate between pages and bytes, Alex Bennée, 2015/02/26