Re: [Qemu-devel] [PATCH target-arm v2 04/13] arm: Refactor get_phys_addr FSR return mechanism

[Peter Maydell]

On 12 June 2015 at 20:10, Peter Crosthwaite
<address@hidden> wrote:
> Currently, the return code for get_phys_addr is overloaded for both
> success/fail and FSR value return. This doesn't handle the case where
> there is an error with a 0 FSR. This case exists in PMSAv7.
>
> So rework get_phys_addr and friends to return a success/failure boolean
> return code and populate the FSR via a caller provided uint32_t
> pointer.

true-on-failure, false-on-success is an odd way round for a
success/failure bool, but I guess it keeps the rest of the code
from changing too much...

-- PMM