[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 01/11] softmmu: add helper function to pass t
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH v5 01/11] softmmu: add helper function to pass through retaddr |
Date: |
Mon, 6 Jul 2015 12:22:51 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On 2015-07-06 11:25, Pavel Dovgalyuk wrote:
> This patch introduces several helpers to pass return address
> which points to the TB. Correct return address allows correct
> restoring of the guest PC and icount. These functions should be used when
> helpers embedded into TB invoke memory operations.
>
> Reviewed-by: Richard Henderson <address@hidden>
Given that you have changed the patch, the reviewed-by should have been
removed.
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
> ---
> include/exec/cpu_ldst_template.h | 59
> +++++++++++++++++++++++++----
> include/exec/cpu_ldst_useronly_template.h | 25 ++++++++++++
> softmmu_template.h | 6 ---
> tcg/tcg.h | 23 +++++++++++
> 4 files changed, 99 insertions(+), 14 deletions(-)
>
That said it looks fine to me, so you can add mine:
Reviewed-by: Aurelien Jarno <address@hidden>
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
address@hidden http://www.aurel32.net
- [Qemu-devel] [PATCH v5 00/11] Fix exceptions handling for MIPS, PowerPC, and i386, Pavel Dovgalyuk, 2015/07/06
- [Qemu-devel] [PATCH v5 01/11] softmmu: add helper function to pass through retaddr, Pavel Dovgalyuk, 2015/07/06
- Re: [Qemu-devel] [PATCH v5 01/11] softmmu: add helper function to pass through retaddr,
Aurelien Jarno <=
- [Qemu-devel] [PATCH v5 02/11] cpu-exec: introduce loop exit with restore function, Pavel Dovgalyuk, 2015/07/06
- [Qemu-devel] [PATCH v5 04/11] target-i386: introduce new raise_exception functions, Pavel Dovgalyuk, 2015/07/06
- [Qemu-devel] [PATCH v5 05/11] target-i386: exception handling for FPU instructions, Pavel Dovgalyuk, 2015/07/06
- Re: [Qemu-devel] [PATCH v5 05/11] target-i386: exception handling for FPU instructions, Aurelien Jarno, 2015/07/06