[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/11] target-m68k: Remove incorrect clearing of
From: |
Andreas Schwab |
Subject: |
Re: [Qemu-devel] [PATCH 03/11] target-m68k: Remove incorrect clearing of cc_x |
Date: |
Fri, 14 Aug 2015 19:04:21 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Richard Henderson <address@hidden> writes:
> The CF docs certainly doesnt suggest this is true.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> target-m68k/helper.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/target-m68k/helper.c b/target-m68k/helper.c
> index c7b0fbe..6feb4bf 100644
> --- a/target-m68k/helper.c
> +++ b/target-m68k/helper.c
> @@ -205,19 +205,12 @@ static uint32_t cpu_m68k_flush_flags(CPUM68KState *env,
> int op)
> break;
> case CC_OP_LOGICB:
> SET_NZ(dest, int8_t);
> - goto set_x;
> break;
> case CC_OP_LOGICW:
> SET_NZ(dest, int16_t);
> - goto set_x;
> break;
> case CC_OP_LOGIC:
> SET_NZ(dest, int32_t);
> -set_x:
> - if (!m68k_feature(env, M68K_FEATURE_M68000)) {
> - /* Unlike m68k, coldfire always clears the overflow bit. */
I think this refers to the muls/mulu insn, where the CF always clears V.
Andreas.
--
Andreas Schwab, address@hidden
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
- [Qemu-devel] [PATCH 00/11] Proposed format for m68k flags, Richard Henderson, 2015/08/14
- [Qemu-devel] [PATCH 04/11] target-m68k: Replace helper_xflag_lt with setcond, Richard Henderson, 2015/08/14
- [Qemu-devel] [PATCH 07/11] target-m68k: Use setcond for scc, Richard Henderson, 2015/08/14
- [Qemu-devel] [PATCH 08/11] target-m68k: Optimize some comparisons, Richard Henderson, 2015/08/14
- [Qemu-devel] [PATCH 09/11] target-m68k: Optimize gen_flush_flags, Richard Henderson, 2015/08/14
- [Qemu-devel] [PATCH 10/11] target-m68k: Inline shifts, Richard Henderson, 2015/08/14
- [Qemu-devel] [PATCH 06/11] target-m68k: Introduce DisasCompare, Richard Henderson, 2015/08/14
- [Qemu-devel] [PATCH 11/11] target-m68k: Inline addx, subx, negx, Richard Henderson, 2015/08/14
- [Qemu-devel] [PATCH 05/11] target-m68k: Reorg flags handling, Richard Henderson, 2015/08/14