qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v8 06/54] Rename mis->file to from_src_file


From: Amit Shah
Subject: Re: [Qemu-devel] [PATCH v8 06/54] Rename mis->file to from_src_file
Date: Tue, 29 Sep 2015 16:11:47 +0530

On (Tue) 29 Sep 2015 [09:37:30], Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
> 
> 'file' becomes confusing when you have flows in each direction;
> rename to make it clear.
> This leaves just the main forward direction ms->file, which is used
> in a lot of places and is probably not worth renaming given the churn.
> 
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>

Reviewed-by: Amit Shah <address@hidden>

I guess we could drop the '_file' in from_src_file too w/o loss of
info.

Also, if you have to respin, description has a typo: ms->file instead
of mis->file.

                Amit



reply via email to

[Prev in Thread] Current Thread [Next in Thread]