Re: [Qemu-devel] [PULL 08/15] i440fx: print an error message if user tries to enable iommu

[Michael S. Tsirkin]

On Thu, Nov 19, 2015 at 03:55:35PM -0500, Bandan Das wrote:
> "Michael S. Tsirkin" <address@hidden> writes:
> 
> > On Thu, Nov 19, 2015 at 03:38:03PM -0500, Bandan Das wrote:
> >> "Michael S. Tsirkin" <address@hidden> writes:
> >> 
> >> > From: Bandan Das <address@hidden>
> >> >
> >> > There's no indication of any sort that i440fx doesn't support
> >> > "iommu=on"
> >> 
> >> Oh, Markus quite didn't like this approach because this is
> >> true for all other machines too. Anyway, I will keep in
> >> mind to take care of this when I post a generic patch. 
> >
> > Do you think I should revert this one then?
> 
> Yes please, if you can. Or else, I will fix it up when I post
> a generic patch later.

Revert these two then?
commit 8d211f622b11ac2877c344f29de284d5a842d9d7
Author: Bandan Das <address@hidden>
Date:   Fri Nov 13 01:55:48 2015 -0500

    i440fx: print an error message if user tries to enable iommu
    
    There's no indication of any sort that i440fx doesn't support
    "iommu=on"
    
    Reviewed-by: Eric Blake <address@hidden>
    Signed-off-by: Bandan Das <address@hidden>
    Reviewed-by: Michael S. Tsirkin <address@hidden>
    Signed-off-by: Michael S. Tsirkin <address@hidden>
    Reviewed-by: Eric Blake <address@hidden>
    Signed-off-by: Bandan Das <address@hidden>

commit 1f8431f42d833e8914f2d16ce4a49b7b72b90db0
Author: Bandan Das <address@hidden>
Date:   Fri Nov 13 01:55:47 2015 -0500

    q35: Check propery to determine if iommu is set
    
    The helper function machine_iommu() isn't necesary. We can
    directly check for the property.
    
    Signed-off-by: Bandan Das <address@hidden>
    Reviewed-by: Michael S. Tsirkin <address@hidden>
    Signed-off-by: Michael S. Tsirkin <address@hidden>
    Signed-off-by: Bandan Das <address@hidden>

Or just one of these?

> >> > Reviewed-by: Eric Blake <address@hidden>
> >> > Signed-off-by: Bandan Das <address@hidden>
> >> > Reviewed-by: Michael S. Tsirkin <address@hidden>
> >> > Signed-off-by: Michael S. Tsirkin <address@hidden>
> >> > Reviewed-by: Eric Blake <address@hidden>
> >> > Signed-off-by: Bandan Das <address@hidden>
> >> > ---
> >> >  hw/pci-host/piix.c | 5 +++++
> >> >  1 file changed, 5 insertions(+)
> >> >
> >> > diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
> >> > index 7b2fbf9..715208b 100644
> >> > --- a/hw/pci-host/piix.c
> >> > +++ b/hw/pci-host/piix.c
> >> > @@ -34,6 +34,7 @@
> >> >  #include "sysemu/sysemu.h"
> >> >  #include "hw/i386/ioapic.h"
> >> >  #include "qapi/visitor.h"
> >> > +#include "qemu/error-report.h"
> >> >  
> >> >  /*
> >> >   * I440FX chipset data sheet.
> >> > @@ -301,6 +302,10 @@ static void i440fx_pcihost_realize(DeviceState 
> >> > *dev, Error **errp)
> >> >  static void i440fx_realize(PCIDevice *dev, Error **errp)
> >> >  {
> >> >      dev->config[I440FX_SMRAM] = 0x02;
> >> > +
> >> > +    if (object_property_get_bool(qdev_get_machine(), "iommu", NULL)) {
> >> > +        error_report("warning: i440fx doesn't support emulated iommu");
> >> > +    }
> >> >  }
> >> >  
> >> >  PCIBus *i440fx_init(const char *host_type, const char *pci_type,