|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event DUMP_COMPLETED |
| Date: | Fri, 27 Nov 2015 11:15:35 +0100 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 27/11/2015 03:48, Peter Xu wrote:
> +##
> +# @DUMP_COMPLETED
> +#
> +# Emitted when background dump has completed
> +#
> +# Since: 2.6
> +##
> +{ 'event': 'DUMP_COMPLETED' ,
> + 'data': { 'msg': 'str' } }
This makes it hard to understand whether there was an error or not. I
suggest using '*error': 'str' instead, and omitting the error if the
dump is successful.
Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |