[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Error handling in realize() methods
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] Error handling in realize() methods |
Date: |
Wed, 9 Dec 2015 14:43:23 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 09/12/2015 14:12, Dr. David Alan Gilbert wrote:
>> > Even if we don't, we should use &error_abort, not &error_fatal
>> > (programmer error---due to laziness---rather than user error).
>> > &error_fatal should really be restricted to code that is running very
>> > close to main().
> No, we used to have error_abort and changed them out for error_fatal because
> we were getting flooded with crash reports due to the aborts of people trying
> to run VMs too big for their machine.
That's a different call site, it's memory_region_allocate_system_memory
and it currently does a manual error_report_err+exit(1). That one is
okay, because it's indeed running "very close to main()" (it's called by
machine_class->init, which is called by main). It could be kept
open-coded or changed to error_fatal.
Paolo
- Re: [Qemu-devel] Error handling in realize() methods, (continued)
- Re: [Qemu-devel] Error handling in realize() methods, Peter Maydell, 2015/12/09
- Re: [Qemu-devel] Error handling in realize() methods, Laszlo Ersek, 2015/12/09
- Re: [Qemu-devel] Error handling in realize() methods, Dr. David Alan Gilbert, 2015/12/09
- Re: [Qemu-devel] Error handling in realize() methods, Markus Armbruster, 2015/12/10
- Re: [Qemu-devel] Error handling in realize() methods, Paolo Bonzini, 2015/12/09
- Re: [Qemu-devel] Error handling in realize() methods, Dr. David Alan Gilbert, 2015/12/09
- Re: [Qemu-devel] Error handling in realize() methods,
Paolo Bonzini <=
- Re: [Qemu-devel] Error handling in realize() methods, Markus Armbruster, 2015/12/10
- Re: [Qemu-devel] Error handling in realize() methods, Dr. David Alan Gilbert, 2015/12/10
- Re: [Qemu-devel] Error handling in realize() methods, Paolo Bonzini, 2015/12/10
- Re: [Qemu-devel] Error handling in realize() methods, Paolo Bonzini, 2015/12/10
- Re: [Qemu-devel] Error handling in realize() methods, Markus Armbruster, 2015/12/10