qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 14/15] Don't include qemu-common.h in headers


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 14/15] Don't include qemu-common.h in headers
Date: Tue, 15 Mar 2016 16:55:07 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0


On 15/03/2016 16:03, Markus Armbruster wrote:
> diff --git a/include/hw/hw.h b/include/hw/hw.h
> index 2cb69d5..151d65e 100644
> --- a/include/hw/hw.h
> +++ b/include/hw/hw.h
> @@ -15,6 +15,7 @@
>  #include "qemu/module.h"
>  
>  #ifdef NEED_CPU_H
> +#include "cpu.h"
>  #if TARGET_LONG_BITS == 64
>  #define qemu_put_betl qemu_put_be64
>  #define qemu_get_betl qemu_get_be64

This actually makes things somewhat worse.  This dependency of hw/hw.h
on NEED_CPU_H should go away altogether.

Would it be okay to stick to patches 1-13 for now?

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]