Re: [Qemu-devel] [PATCH 14/15] Don't include qemu-common.h in headers

[Markus Armbruster]

Peter Maydell <address@hidden> writes:

> On 15 March 2016 at 17:25, Paolo Bonzini <address@hidden> wrote:
>> Since I have your attention, what about getting rid of fprintf-fn.h and
>> moving it into qemu/osdep.h?
>
> Not a lot very osdep-ish about it... If you're going to put it anywhere
> then typedefs.h seems more appropriate.

Makes sense to me.

> (It's in its own file at the moment as part of a previous idea of
> cleaning up qemu-common.h by splitting it into separate parts where
> necessary so that only the needed parts could be included by the
> code that wanted them.)

Sensible idea, but fprintf_function is hardly worth its very own header.
typedefs.h should do nicely.