Re: [Qemu-devel] [PATCH 02/33] acpi: add aml_debug()

[Marcel Apfelbaum]

On 05/17/2016 05:42 PM, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
>   hw/acpi/aml-build.c         | 9 +++++++++
>   include/hw/acpi/aml-build.h | 1 +
>   2 files changed, 10 insertions(+)
>
> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> index cedb74e..f7d99be 100644
> --- a/hw/acpi/aml-build.c
> +++ b/hw/acpi/aml-build.c
> @@ -406,6 +406,15 @@ Aml *aml_return(Aml *val)
>       return var;
>   }
>
> +/* ACPI 1.0b: 16.2.6.3 Debug Objects Encoding: DebugObj */
> +Aml *aml_debug(void)
> +{
> +    Aml *var = aml_alloc();
> +    build_append_byte(var->buf, 0x5B); /* ExtOpPrefix */
> +    build_append_byte(var->buf, 0x31); /* DebugOp */
> +    return var;
> +}
> +
>   /*
>    * ACPI 1.0b: 16.2.3 Data Objects Encoding:
>    * encodes: ByteConst, WordConst, DWordConst, QWordConst, ZeroOp, OneOp
> diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
> index 7eb51c7..70a4b14 100644
> --- a/include/hw/acpi/aml-build.h
> +++ b/include/hw/acpi/aml-build.h
> @@ -252,6 +252,7 @@ void aml_append(Aml *parent_ctx, Aml *child);
>   /* non block AML object primitives */
>   Aml *aml_name(const char *name_format, ...) GCC_FMT_ATTR(1, 2);
>   Aml *aml_name_decl(const char *name, Aml *val);
> +Aml *aml_debug(void);
>   Aml *aml_return(Aml *val);
>   Aml *aml_int(const uint64_t val);
>   Aml *aml_arg(int pos);


Reviewed-by: Marcel Apfelbaum <address@hidden>

Thanks,
Marcel