[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH RFC 0/3] Rename of the QObject visitors rearranged
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH RFC 0/3] Rename of the QObject visitors rearranged |
Date: |
Tue, 25 Oct 2016 16:35:04 +0200 |
This is how I propose to rearrange PATCH 04+05 of Dan's "[PATCH v14
00/21] QAPI/QOM work for non-scalar object properties" (really v15) in
my pull request, to make git's rename detection work. The result is
identical except for two comments I touched up:
diff --git a/include/qapi/qobject-output-visitor.h
b/include/qapi/qobject-output-visitor.h
index 358c959..8241877 100644
--- a/include/qapi/qobject-output-visitor.h
+++ b/include/qapi/qobject-output-visitor.h
@@ -20,7 +20,7 @@
typedef struct QObjectOutputVisitor QObjectOutputVisitor;
/*
- * Create a new QOBJECT output visitor.
+ * Create a new QObject output visitor.
*
* If everything else succeeds, pass @result to visit_complete() to
* collect the result of the visit.
diff --git a/qapi/qobject-output-visitor.c b/qapi/qobject-output-visitor.c
index df43cb8..8711270 100644
--- a/qapi/qobject-output-visitor.c
+++ b/qapi/qobject-output-visitor.c
@@ -150,7 +150,7 @@ static void qobject_output_type_int64(Visitor *v, const
char *name,
static void qobject_output_type_uint64(Visitor *v, const char *name,
uint64_t *obj, Error **errp)
{
- /* FIXME: QOBJECT outputs values larger than INT64_MAX as negative */
+ /* FIXME values larger than INT64_MAX become negative */
QObjectOutputVisitor *qov = to_qov(v);
qobject_output_add(qov, name, qint_from_int(*obj));
}
Daniel P. Berrange (3):
qapi: rename *qmp-*-visitor* to *qobject-*-visitor*
qapi: rename QmpInputVisitor to QObjectInputVisitor
qapi: rename QmpOutputVisitor to QObjectOutputVisitor
block/qapi.c | 4 +-
blockdev.c | 4 +-
docs/qapi-code-gen.txt | 4 +-
...qmp-input-visitor.h => qobject-input-visitor.h} | 10 +-
...p-output-visitor.h => qobject-output-visitor.h} | 10 +-
include/qapi/visitor.h | 6 +-
monitor.c | 2 +-
qapi/Makefile.objs | 4 +-
qapi/qapi-clone-visitor.c | 2 +-
qapi/qmp-output-visitor.c | 256 ---------------------
...qmp-input-visitor.c => qobject-input-visitor.c} | 170 +++++++-------
qapi/qobject-output-visitor.c | 254 ++++++++++++++++++++
qemu-img.c | 8 +-
qmp.c | 4 +-
qom/object_interfaces.c | 2 +-
qom/qom-qobject.c | 8 +-
scripts/qapi-commands.py | 8 +-
scripts/qapi-event.py | 4 +-
target-s390x/cpu_models.c | 4 +-
tests/.gitignore | 6 +-
tests/Makefile.include | 20 +-
tests/check-qnull.c | 8 +-
tests/test-qmp-commands.c | 4 +-
...-input-strict.c => test-qobject-input-strict.c} | 6 +-
...nput-visitor.c => test-qobject-input-visitor.c} | 6 +-
...put-visitor.c => test-qobject-output-visitor.c} | 6 +-
tests/test-string-input-visitor.c | 2 +-
tests/test-string-output-visitor.c | 2 +-
tests/test-visitor-serialization.c | 8 +-
util/qemu-sockets.c | 4 +-
30 files changed, 418 insertions(+), 418 deletions(-)
rename include/qapi/{qmp-input-visitor.h => qobject-input-visitor.h} (63%)
rename include/qapi/{qmp-output-visitor.h => qobject-output-visitor.h} (66%)
delete mode 100644 qapi/qmp-output-visitor.c
rename qapi/{qmp-input-visitor.c => qobject-input-visitor.c} (59%)
create mode 100644 qapi/qobject-output-visitor.c
rename tests/{test-qmp-input-strict.c => test-qobject-input-strict.c} (98%)
rename tests/{test-qmp-input-visitor.c => test-qobject-input-visitor.c} (99%)
rename tests/{test-qmp-output-visitor.c => test-qobject-output-visitor.c} (99%)
--
2.5.5
- [Qemu-devel] [PATCH RFC 0/3] Rename of the QObject visitors rearranged,
Markus Armbruster <=
- [Qemu-devel] [PATCH RFC 1/3] qapi: rename *qmp-*-visitor* to *qobject-*-visitor*, Markus Armbruster, 2016/10/25
- [Qemu-devel] [PATCH RFC 3/3] qapi: rename QmpOutputVisitor to QObjectOutputVisitor, Markus Armbruster, 2016/10/25
- [Qemu-devel] [PATCH RFC 2/3] qapi: rename QmpInputVisitor to QObjectInputVisitor, Markus Armbruster, 2016/10/25
- Re: [Qemu-devel] [PATCH RFC 0/3] Rename of the QObject visitors rearranged, Daniel P. Berrange, 2016/10/25
- Re: [Qemu-devel] [PATCH RFC 0/3] Rename of the QObject visitors rearranged, Eric Blake, 2016/10/25