[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 0/3] Rename of the QObject visitors rearrang
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH RFC 0/3] Rename of the QObject visitors rearranged |
Date: |
Tue, 25 Oct 2016 17:49:14 +0200 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Tue, Oct 25, 2016 at 04:35:04PM +0200, Markus Armbruster wrote:
> This is how I propose to rearrange PATCH 04+05 of Dan's "[PATCH v14
> 00/21] QAPI/QOM work for non-scalar object properties" (really v15) in
> my pull request, to make git's rename detection work. The result is
> identical except for two comments I touched up:
>
> diff --git a/include/qapi/qobject-output-visitor.h
> b/include/qapi/qobject-output-visitor.h
> index 358c959..8241877 100644
> --- a/include/qapi/qobject-output-visitor.h
> +++ b/include/qapi/qobject-output-visitor.h
> @@ -20,7 +20,7 @@
> typedef struct QObjectOutputVisitor QObjectOutputVisitor;
>
> /*
> - * Create a new QOBJECT output visitor.
> + * Create a new QObject output visitor.
> *
> * If everything else succeeds, pass @result to visit_complete() to
> * collect the result of the visit.
> diff --git a/qapi/qobject-output-visitor.c b/qapi/qobject-output-visitor.c
> index df43cb8..8711270 100644
> --- a/qapi/qobject-output-visitor.c
> +++ b/qapi/qobject-output-visitor.c
> @@ -150,7 +150,7 @@ static void qobject_output_type_int64(Visitor *v, const
> char *name,
> static void qobject_output_type_uint64(Visitor *v, const char *name,
> uint64_t *obj, Error **errp)
> {
> - /* FIXME: QOBJECT outputs values larger than INT64_MAX as negative */
> + /* FIXME values larger than INT64_MAX become negative */
> QObjectOutputVisitor *qov = to_qov(v);
> qobject_output_add(qov, name, qint_from_int(*obj));
> }
Looks fine to me.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|