Re: [Qemu-devel] [PULL 00/11] Changes to -drive without if= and with if=scsi

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PULL 00/11] Changes to -drive without if= and with 
if=scsi
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
8bfef42 hw/i386: Deprecate -drive if=scsi with PC machine types
7638d3f hw: Deprecate -drive if=scsi with non-onboard HBAs
dc17149 hw/scsi: Concentrate -drive if=scsi auto-create in one place
6196006 hw: Drop superfluous special checks for orphaned -drive
3d87f86 blockdev: Make orphaned -drive fatal
a7472ca blockdev: Improve message for orphaned -drive
781e308 hw/arm/highbank: Default -drive to if=ide instead of if=scsi
04b725b hw: Default -drive to if=none instead of scsi when scsi cannot work
cecd7a2 hw: Default -drive to if=none instead of ide when ide cannot work
027c597 hw/arm/cubieboard hw/arm/xlnx-ep108: Fix units_per_default_bus
ccfec9e hw: Default -drive to if=ide explicitly where it works

=== OUTPUT BEGIN ===
Checking PATCH 1/11: hw: Default -drive to if=ide explicitly where it works...
Checking PATCH 2/11: hw/arm/cubieboard hw/arm/xlnx-ep108: Fix 
units_per_default_bus...
Checking PATCH 3/11: hw: Default -drive to if=none instead of ide when ide 
cannot work...
Checking PATCH 4/11: hw: Default -drive to if=none instead of scsi when scsi 
cannot work...
Checking PATCH 5/11: hw/arm/highbank: Default -drive to if=ide instead of 
if=scsi...
Checking PATCH 6/11: blockdev: Improve message for orphaned -drive...
Checking PATCH 7/11: blockdev: Make orphaned -drive fatal...
Checking PATCH 8/11: hw: Drop superfluous special checks for orphaned -drive...
Checking PATCH 9/11: hw/scsi: Concentrate -drive if=scsi auto-create in one 
place...
Checking PATCH 10/11: hw: Deprecate -drive if=scsi with non-onboard HBAs...
Checking PATCH 11/11: hw/i386: Deprecate -drive if=scsi with PC machine types...
ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#72: FILE: tests/qemu-iotests/051.pc.out:122:
+qququiquit
  ^

ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#92: FILE: tests/qemu-iotests/051.pc.out:178:
+qququiquit
  ^

ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#102: FILE: tests/qemu-iotests/051.pc.out:188:
+qququiquit
  ^

total: 3 errors, 0 warnings, 63 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden