Re: [Qemu-devel] [PATCH v1 3/3] s390x/cpumodel: allow to enable MVCOS for qemu cpu model

[Thomas Huth]

On 14.06.2017 09:03, David Hildenbrand wrote:
> On 14.06.2017 06:44, Richard Henderson wrote:
>> On 06/13/2017 02:47 PM, David Hildenbrand wrote:
>>> +    if (!s390_has_feat(S390_FEAT_MOVE_WITH_OPTIONAL_SPEC)) {
>>> +        program_interrupt(env, PGM_OPERATION, 6);
>>> +    }
>>
>> This is (supposed to be) done via the feature field of insn-data.def.
>>
>> Except that we do not yet enforce that; we haven't updated that bit of the 
>> translator since we actually added support for the feature bits.
> 
> That makes sense, I'll drop this hunk then.
I think you could then also simply put the one-line-change to
target/s390x/cpu_models.c into the previous patch instead.

 Thomas