[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH v2 15/26] replay/replay-internal.c: track holdin
From: |
Pavel Dovgalyuk |
Subject: |
[Qemu-devel] [RFC PATCH v2 15/26] replay/replay-internal.c: track holding of replay_lock |
Date: |
Tue, 14 Nov 2017 11:17:55 +0300 |
User-agent: |
StGit/0.17.1-dirty |
From: Alex Bennée <address@hidden>
This is modelled after the iothread mutex lock. We keep a TLS flag to
indicate when that thread has acquired the lock and assert we don't
double-lock or release when we shouldn't have.
Signed-off-by: Alex Bennée <address@hidden>
Tested-by: Pavel Dovgalyuk <address@hidden>
---
replay/replay-internal.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/replay/replay-internal.c b/replay/replay-internal.c
index fca8514..157c863 100644
--- a/replay/replay-internal.c
+++ b/replay/replay-internal.c
@@ -179,13 +179,24 @@ void replay_mutex_destroy(void)
qemu_mutex_destroy(&lock);
}
+static __thread bool replay_locked;
+
+static bool replay_mutex_locked(void)
+{
+ return replay_locked;
+}
+
void replay_mutex_lock(void)
{
+ g_assert(!replay_mutex_locked());
qemu_mutex_lock(&lock);
+ replay_locked = true;
}
void replay_mutex_unlock(void)
{
+ g_assert(replay_mutex_locked());
+ replay_locked = false;
qemu_mutex_unlock(&lock);
}
- [Qemu-devel] [RFC PATCH v2 08/26] replay: make safe vmstop at record/replay, (continued)
- [Qemu-devel] [RFC PATCH v2 08/26] replay: make safe vmstop at record/replay, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 09/26] replay: save prior value of the host clock, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 10/26] icount: fixed saving/restoring of icount warp timers, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 11/26] target/arm/arm-powertctl: drop BQL assertions, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 12/26] cpus: push BQL lock to qemu_*_wait_io_event, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 13/26] cpus: only take BQL for sleeping threads, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 14/26] replay/replay.c: bump REPLAY_VERSION again, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 15/26] replay/replay-internal.c: track holding of replay_lock,
Pavel Dovgalyuk <=
- [Qemu-devel] [RFC PATCH v2 16/26] replay: make locking visible outside replay code, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 17/26] replay: push replay_mutex_lock up the call tree, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 18/26] cpu-exec: don't overwrite exception_index, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 19/26] cpu-exec: reset exit flag before calling cpu_exec_nocache, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 20/26] replay: don't destroy mutex at exit, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 21/26] replay: check return values of fwrite, Pavel Dovgalyuk, 2017/11/14