[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 18/26] cpu-exec: don't overwrite exceptio
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 18/26] cpu-exec: don't overwrite exception_index |
Date: |
Tue, 14 Nov 2017 14:37:53 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 14/11/2017 09:18, Pavel Dovgalyuk wrote:
> This patch adds a condition before overwriting exception_index fiels.
> It is needed when exception_index is already set to some meaningful value.
>
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
>
> ---
> accel/tcg/cpu-exec.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
> index 61297f8..0473055 100644
> --- a/accel/tcg/cpu-exec.c
> +++ b/accel/tcg/cpu-exec.c
> @@ -594,7 +594,9 @@ static inline bool cpu_handle_interrupt(CPUState *cpu,
> if (unlikely(atomic_read(&cpu->exit_request)
> || (use_icount && cpu->icount_decr.u16.low + cpu->icount_extra ==
> 0))) {
> atomic_set(&cpu->exit_request, 0);
> - cpu->exception_index = EXCP_INTERRUPT;
> + if (cpu->exception_index == -1) {
> + cpu->exception_index = EXCP_INTERRUPT;
> + }
> return true;
> }
>
>
Thanks, queued for 2.11.
Paolo
- Re: [Qemu-devel] [RFC PATCH v2 10/26] icount: fixed saving/restoring of icount warp timers, (continued)
- [Qemu-devel] [RFC PATCH v2 11/26] target/arm/arm-powertctl: drop BQL assertions, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 12/26] cpus: push BQL lock to qemu_*_wait_io_event, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 13/26] cpus: only take BQL for sleeping threads, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 14/26] replay/replay.c: bump REPLAY_VERSION again, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 15/26] replay/replay-internal.c: track holding of replay_lock, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 16/26] replay: make locking visible outside replay code, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 17/26] replay: push replay_mutex_lock up the call tree, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 18/26] cpu-exec: don't overwrite exception_index, Pavel Dovgalyuk, 2017/11/14
- Re: [Qemu-devel] [RFC PATCH v2 18/26] cpu-exec: don't overwrite exception_index,
Paolo Bonzini <=
- [Qemu-devel] [RFC PATCH v2 19/26] cpu-exec: reset exit flag before calling cpu_exec_nocache, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 20/26] replay: don't destroy mutex at exit, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 21/26] replay: check return values of fwrite, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 22/26] scripts/qemu-gdb: add simple tcg lock status helper, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 23/26] util/qemu-thread-*: add qemu_lock, locked and unlock trace events, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 24/26] scripts/analyse-locks-simpletrace.py: script to analyse lock times, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 25/26] scripts/replay-dump.py: replay log dumper, Pavel Dovgalyuk, 2017/11/14