Re: [Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator

[Philippe Mathieu-Daudé]

On 01/08/2018 02:10 PM, Peter Maydell wrote:
> In commit c97d6d2cdf97ed we accidentally added code to configure
> that uses '==' for string equality testing. This is a bashism --
> the portable way to write this is '='.
> 
> This fixes the "Unexpected operator error" complaint produced
> if the system /bin/sh is dash.

Thanks :)

> 
> Fixes: c97d6d2cdf97ed
> Reported-by: Philippe Mathieu-Daudé <address@hidden>
> Signed-off-by: Peter Maydell <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>

> ---
> As an aside, it's annoying that this doesn't make configure fail;
> otherwise it wouldn't have got through my build tests.
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 56f9716..6a04082 100755
> --- a/configure
> +++ b/configure
> @@ -5076,7 +5076,7 @@ fi
>  
>  #################################################
>  # Check to see if we have the Hypervisor framework
> -if [ "$darwin" == "yes" ] ; then
> +if [ "$darwin" = "yes" ] ; then
>    cat > $TMPC << EOF
>  #include <Hypervisor/hv.h>
>  int main() { return 0;}
>

signature.asc
Description: OpenPGP digital signature