qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 14/67] target/arm: Implement SVE Integer Arit


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v2 14/67] target/arm: Implement SVE Integer Arithmetic - Unary Predicated Group
Date: Fri, 23 Feb 2018 17:30:54 +0000

On 23 February 2018 at 17:25, Richard Henderson
<address@hidden> wrote:
> On 02/23/2018 05:08 AM, Peter Maydell wrote:
>>> +# SVE unary bit operations (predicated)
>>> +# Note esz != 0 for FABS and FNEG.
>>> +CLS            00000100 .. 011 000 101 ... ..... .....         @rd_pg_rn
>>> +CLZ            00000100 .. 011 001 101 ... ..... .....         @rd_pg_rn
>>> +CNT_zpz                00000100 .. 011 010 101 ... ..... .....         
>>> @rd_pg_rn
>>> +CNOT           00000100 .. 011 011 101 ... ..... .....         @rd_pg_rn
>>> +NOT_zpz                00000100 .. 011 110 101 ... ..... .....         
>>> @rd_pg_rn
>>> +FABS           00000100 .. 011 100 101 ... ..... .....         @rd_pg_rn
>>> +FNEG           00000100 .. 011 101 101 ... ..... .....         @rd_pg_rn
>>
>> Indentation seems to be a bit skew for the _zpz lines.
>
> There are tabs in here.  I know they're not allowed for C, but this isn't.

I don't think we should have tabs in these files either for the
same reasons we don't have them in C code.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]