Re: [Qemu-devel] [PATCH 00/35] nanoMIPS

[Philippe Mathieu-Daudé]

Hi Aleksandar,

On 06/22/2018 11:39 AM, Aleksandar Markovic wrote:
>> From: Philippe Mathieu-Daudé <address@hidden> on behalf of Philippe 
>> Mathieu-Daudé <address@hidden>
>> Sent: Friday, June 22, 2018 6:26 AM
>> To: Yongbok Kim; James Hogan
>> Cc: address@hidden; Aleksandar Markovic; Paul Burton; Stefan Markovic; 
>> Matthew Fortune; address@hidden; Paul Burton
>> Subject: Re: [Qemu-devel] [PATCH 00/35] nanoMIPS
>>
>> Hi Yongbok,
>>
>> On 06/20/2018 09:05 AM, Yongbok Kim wrote:
>>> This series of patches is implementing recently announced nanoMIPS on QEMU.
>>> nanoMIPS is a variable length ISA containing 16, 32 and 48 bit wide
>>> instructions. It is designed to be portable at assembly level with other 
>>> MIPS
>>> and microMIPS code, but contains a number of changes which enhance code 
>>> density
>>> and efficiency.
>> [...]
>>
>> I noticed various patches use the imgtec.com domain.
>>
>> In commit 94d973bdaac Paul Burton wrote:
>>
>>     MIPS will soon no longer be a part of Imagination Technologies
>>     & as such the @imgtec.com address will soon cease to function.
>>
>> Your's got updated in 0eb4e1f33a4, and James in a7a2d7d2a04.
>>
>> Assuming this is rebase using previous internal patches, shouldn't you
>> update those addresses to your new domain? Else the checkpatch.pl script
>> will continue to extract imgtec.com addresses from commits.
> 
> Thanks for spotting this, Philippe! It probably slipped through the cracks.
> 
> If nobody objects, while integrating/applying, I am going to change all 
> instances of "@imgtec.com" to "@mips.com" for this series.
> 
> Some of the patches might have been developed while the company was part of 
> Imagination Technologies - however, I think it is reasonable to use email 
> addresses at the moment of submitting changes to this list. This gets 
> complicated if, for example, a person leaves the company before his/her email 
> address changes, but I think, in this case, using "@mips.com" is appropriate 
> for all involved persons.

Well, since imgtec.com entries are in .mailmap, and get_maintainer.pl
parses it, maybe there is a bug in the script.

The 'From' is used for the git author, and IMO should be @mips.com.

To respect Imagination Technologies efforts, can this work?

Signed-off-by: James Hogan <address@hidden> for Imagination
Technologies

This shouldn't break scripts. However not all names fit in less than 80
characters...

> 
> Regards,
> 
> Aleksandar
> 
>>
>> Regards,
>>
>> Phil.