[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/35] tcg: access cpu->icount_decr.u16.high wit
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 01/35] tcg: access cpu->icount_decr.u16.high with atomics |
Date: |
Tue, 18 Sep 2018 13:46:54 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 9/17/18 9:30 AM, Emilio G. Cota wrote:
> Consistently access u16.high with atomics to avoid
> undefined behaviour in MTTCG.
>
> Note that icount_decr.u16.low is only used in icount mode,
> so regular accesses to it are OK.
>
> Cc: Peter Crosthwaite <address@hidden>
> Cc: Richard Henderson <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
> accel/tcg/tcg-all.c | 2 +-
> accel/tcg/translate-all.c | 2 +-
> qom/cpu.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
Eh, sure, I guess.
Reviewed-by: Richard Henderson <address@hidden>
r~
- Re: [Qemu-devel] [PATCH 11/35] target/i386: access cpu->interrupt_request with atomics, (continued)
- [Qemu-devel] [PATCH 10/35] target/hppa: access cpu->interrupt_request with atomics, Emilio G. Cota, 2018/09/17
- [Qemu-devel] [PATCH 08/35] target/arm: access cpu->interrupt_request with atomics, Emilio G. Cota, 2018/09/17
- [Qemu-devel] [PATCH 02/35] target/i386: use cpu_reset_interrupt, Emilio G. Cota, 2018/09/17
- [Qemu-devel] [PATCH 18/35] target/mips: access cpu->interrupt_request with atomics, Emilio G. Cota, 2018/09/17
- [Qemu-devel] [PATCH 01/35] tcg: access cpu->icount_decr.u16.high with atomics, Emilio G. Cota, 2018/09/17
- Re: [Qemu-devel] [PATCH 01/35] tcg: access cpu->icount_decr.u16.high with atomics,
Richard Henderson <=
- [Qemu-devel] [PATCH 34/35] exec: push BQL down to cpu->do_interrupt, Emilio G. Cota, 2018/09/17
- [Qemu-devel] [PATCH 16/35] target/m68k: access cpu->interrupt_request with atomics, Emilio G. Cota, 2018/09/17
- [Qemu-devel] [PATCH 20/35] target/nios2: access cpu->interrupt_request with atomics, Emilio G. Cota, 2018/09/17
- [Qemu-devel] [PATCH 13/35] hvf: access cpu->interrupt_request with atomics, Emilio G. Cota, 2018/09/17