Re: [Qemu-devel] [PATCH 03/28] target/riscv: Convert RVXI load/store ins

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 03/28] target/riscv: Convert RVXI load/store ins

From:	Richard Henderson
Subject:	Re: [Qemu-devel] [PATCH 03/28] target/riscv: Convert RVXI load/store insns to decodetree
Date:	Fri, 12 Oct 2018 11:24:05 -0700
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0

On 10/12/18 10:30 AM, Bastian Koppelmann wrote:
> +}
> +static bool trans_lh(DisasContext *ctx, arg_lh *a, uint32_t insn)

Watch your spacing.  Otherwise,
Reviewed-by: Richard Henderson <address@hidden>


r~

[Prev in Thread]

Current Thread

[Next in Thread]

[Qemu-devel] [PATCH 00/28] target/riscv: Convert to decodetree, Bastian Koppelmann, 2018/10/12
- [Qemu-devel] [PATCH 03/28] target/riscv: Convert RVXI load/store insns to decodetree, Bastian Koppelmann, 2018/10/12
  - Re: [Qemu-devel] [PATCH 03/28] target/riscv: Convert RVXI load/store insns to decodetree, Richard Henderson <=
- [Qemu-devel] [PATCH 04/28] target/riscv: Convert RVXI arithmetic insns to decodetree, Bastian Koppelmann, 2018/10/12
  - Re: [Qemu-devel] [PATCH 04/28] target/riscv: Convert RVXI arithmetic insns to decodetree, Richard Henderson, 2018/10/12
    - Re: [Qemu-devel] [PATCH 04/28] target/riscv: Convert RVXI arithmetic insns to decodetree, Bastian Koppelmann, 2018/10/19
    - Re: [Qemu-devel] [PATCH 04/28] target/riscv: Convert RVXI arithmetic insns to decodetree, Palmer Dabbelt, 2018/10/19
- [Qemu-devel] [PATCH 01/28] targer/riscv: Activate decodetree and implemnt LUI & AUIPC, Bastian Koppelmann, 2018/10/12
  - Re: [Qemu-devel] [PATCH 01/28] targer/riscv: Activate decodetree and implemnt LUI & AUIPC, Richard Henderson, 2018/10/12
- [Qemu-devel] [PATCH 07/28] target/riscv: Convert RVXM insns to decodetree, Bastian Koppelmann, 2018/10/12
  - Re: [Qemu-devel] [PATCH 07/28] target/riscv: Convert RVXM insns to decodetree, Richard Henderson, 2018/10/13
- [Qemu-devel] [PATCH 06/28] target/riscv: Convert RVXI csr insns to decodetree, Bastian Koppelmann, 2018/10/12
  - Re: [Qemu-devel] [PATCH 06/28] target/riscv: Convert RVXI csr insns to decodetree, Richard Henderson, 2018/10/13

Prev by Date: Re: [Qemu-devel] [PATCH 02/28] target/riscv: Convert RVXI branch insns to decodetree
Next by Date: Re: [Qemu-devel] [PATCH] Makefile: Install new vgabios binaries
Previous by thread: [Qemu-devel] [PATCH 03/28] target/riscv: Convert RVXI load/store insns to decodetree
Next by thread: [Qemu-devel] [PATCH 04/28] target/riscv: Convert RVXI arithmetic insns to decodetree
Index(es):
- Date
- Thread