[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 34/40] vl: Assert drive_new() does not fail in defaul
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 34/40] vl: Assert drive_new() does not fail in default_drive() |
Date: |
Mon, 22 Oct 2018 14:34:07 +0200 |
If creating (empty) default drives fails, it's a bug. Therefore,
assert() is more appropriate than exit(1).
Cc: Kevin Wolf <address@hidden>
Cc: Max Reitz <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Message-Id: <address@hidden>
---
vl.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/vl.c b/vl.c
index 7cd35d2c37..fbbae766d5 100644
--- a/vl.c
+++ b/vl.c
@@ -1156,9 +1156,7 @@ static void default_drive(int enable, int snapshot,
BlockInterfaceType type,
}
dinfo = drive_new(opts, type);
- if (!dinfo) {
- exit(1);
- }
+ assert(dinfo);
dinfo->is_default = true;
}
--
2.17.2
- [Qemu-devel] [PULL 28/40] ui: Convert vnc_display_init(), init_keyboard_layout() to Error, (continued)
- [Qemu-devel] [PULL 28/40] ui: Convert vnc_display_init(), init_keyboard_layout() to Error, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 33/40] fsdev: Clean up error reporting in qemu_fsdev_add(), Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 09/40] char: Use error_printf() to print help and such, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 21/40] qom: Clean up error reporting in user_creatable_add_opts_foreach(), Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 17/40] numa: Fix QMP command set-numa-node error handling, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 13/40] smbios: Clean up error handling in smbios_add(), Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 14/40] migration: Fix !replay_can_snapshot() error handling, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 02/40] vl: Print error when using incorrect backend for debugcon, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 29/40] vnc: Clean up error reporting in vnc_init_func(), Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 26/40] vl: Clean up error reporting in device_init_func(), Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 34/40] vl: Assert drive_new() does not fail in default_drive(),
Markus Armbruster <=
- [Qemu-devel] [PULL 36/40] vl: Fix exit status for -drive format=help, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 15/40] l2tpv3: Improve -netdev/netdev_add/-net/... error reporting, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 37/40] vl: Simplify call of parse_name(), Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 31/40] tpm: Clean up error reporting in tpm_init_tpmdev(), Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 38/40] block: Clean up bdrv_img_create()'s error reporting, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 18/40] xen/pt: Fix incomplete conversion to realize(), Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 32/40] spice: Clean up error reporting in add_channel(), Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 07/40] vfio: Use warn_report() & friends to report warnings, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 11/40] pc: Fix machine property nvdimm-persistence error handling, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 40/40] error: Drop bogus "use error_setg() instead" admonitions, Markus Armbruster, 2018/10/22