[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 18/40] xen/pt: Fix incomplete conversion to realize()
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 18/40] xen/pt: Fix incomplete conversion to realize() |
Date: |
Mon, 22 Oct 2018 14:33:51 +0200 |
The conversion of "xen-pci-passthrough" to realize() (commit
5a11d0f7549, v2.6.0) neglected to convert the xen_pt_config_init()
error path. If xen_pt_config_init() fails, xen_pt_realize() reports
the error, then returns success without completing its job. I don't
know the exact impact, but it can't be good.
Belatedly convert the error path.
Fixes: 5a11d0f7549e24a10e178a9dc8ff5e698031d9a6
Cc: Stefano Stabellini <address@hidden>
Cc: Anthony Perard <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Acked-by: Anthony PERARD <address@hidden>
Message-Id: <address@hidden>
---
hw/xen/xen_pt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
index e5a6eff44f..f1f3a3727c 100644
--- a/hw/xen/xen_pt.c
+++ b/hw/xen/xen_pt.c
@@ -830,7 +830,7 @@ static void xen_pt_realize(PCIDevice *d, Error **errp)
xen_pt_config_init(s, &err);
if (err) {
error_append_hint(&err, "PCI Config space initialisation failed");
- error_report_err(err);
+ error_propagate(errp, err);
rc = -1;
goto err_out;
}
--
2.17.2
- [Qemu-devel] [PULL 14/40] migration: Fix !replay_can_snapshot() error handling, (continued)
- [Qemu-devel] [PULL 14/40] migration: Fix !replay_can_snapshot() error handling, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 02/40] vl: Print error when using incorrect backend for debugcon, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 29/40] vnc: Clean up error reporting in vnc_init_func(), Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 26/40] vl: Clean up error reporting in device_init_func(), Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 34/40] vl: Assert drive_new() does not fail in default_drive(), Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 36/40] vl: Fix exit status for -drive format=help, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 15/40] l2tpv3: Improve -netdev/netdev_add/-net/... error reporting, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 37/40] vl: Simplify call of parse_name(), Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 31/40] tpm: Clean up error reporting in tpm_init_tpmdev(), Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 38/40] block: Clean up bdrv_img_create()'s error reporting, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 18/40] xen/pt: Fix incomplete conversion to realize(),
Markus Armbruster <=
- [Qemu-devel] [PULL 32/40] spice: Clean up error reporting in add_channel(), Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 07/40] vfio: Use warn_report() & friends to report warnings, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 11/40] pc: Fix machine property nvdimm-persistence error handling, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 40/40] error: Drop bogus "use error_setg() instead" admonitions, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 06/40] cpus hw target: Use warn_report() & friends to report warnings, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 23/40] vl: Clean up error reporting in machine_set_property(), Markus Armbruster, 2018/10/22
- Re: [Qemu-devel] [PULL 00/40] Error reporting patches for 2018-10-22, Peter Maydell, 2018/10/23