[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 37/40] vl: Simplify call of parse_name()
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 37/40] vl: Simplify call of parse_name() |
Date: |
Mon, 22 Oct 2018 14:34:10 +0200 |
main() checks for parse_name() failure even though it can't actually
fail. That's okay. Simplify it to check by passing &error_fatal,
like the other users of qemu_opts_foreach().
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
---
vl.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/vl.c b/vl.c
index 812ceba425..d53e2563e9 100644
--- a/vl.c
+++ b/vl.c
@@ -3974,10 +3974,8 @@ int main(int argc, char **argv, char **envp)
}
#endif
- if (qemu_opts_foreach(qemu_find_opts("name"),
- parse_name, NULL, NULL)) {
- exit(1);
- }
+ qemu_opts_foreach(qemu_find_opts("name"),
+ parse_name, NULL, &error_fatal);
#ifndef _WIN32
qemu_opts_foreach(qemu_find_opts("add-fd"),
--
2.17.2
- [Qemu-devel] [PULL 21/40] qom: Clean up error reporting in user_creatable_add_opts_foreach(), (continued)
- [Qemu-devel] [PULL 21/40] qom: Clean up error reporting in user_creatable_add_opts_foreach(), Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 17/40] numa: Fix QMP command set-numa-node error handling, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 13/40] smbios: Clean up error handling in smbios_add(), Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 14/40] migration: Fix !replay_can_snapshot() error handling, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 02/40] vl: Print error when using incorrect backend for debugcon, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 29/40] vnc: Clean up error reporting in vnc_init_func(), Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 26/40] vl: Clean up error reporting in device_init_func(), Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 34/40] vl: Assert drive_new() does not fail in default_drive(), Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 36/40] vl: Fix exit status for -drive format=help, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 15/40] l2tpv3: Improve -netdev/netdev_add/-net/... error reporting, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 37/40] vl: Simplify call of parse_name(),
Markus Armbruster <=
- [Qemu-devel] [PULL 31/40] tpm: Clean up error reporting in tpm_init_tpmdev(), Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 38/40] block: Clean up bdrv_img_create()'s error reporting, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 18/40] xen/pt: Fix incomplete conversion to realize(), Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 32/40] spice: Clean up error reporting in add_channel(), Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 07/40] vfio: Use warn_report() & friends to report warnings, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 11/40] pc: Fix machine property nvdimm-persistence error handling, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 40/40] error: Drop bogus "use error_setg() instead" admonitions, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 06/40] cpus hw target: Use warn_report() & friends to report warnings, Markus Armbruster, 2018/10/22
- [Qemu-devel] [PULL 23/40] vl: Clean up error reporting in machine_set_property(), Markus Armbruster, 2018/10/22
- Re: [Qemu-devel] [PULL 00/40] Error reporting patches for 2018-10-22, Peter Maydell, 2018/10/23