Re: [Qemu-ppc] [PATCH RFC v0 2/6] target-ppc: add vabsdu[b, h, w] instructions

[David Gibson]

On Wed, Jul 27, 2016 at 12:56:54AM +0530, Nikunj A Dadhania wrote:
> From: Sandipan Das <address@hidden>
> 
> Adds following instructions:
> 
> vabsdub: Vector Absolute Difference Unsigned Byte
> vabsduh: Vector Absolute Difference Unsigned Halfword
> vabsduw: Vector Absolute Difference Unsigned Word
> 
> Signed-off-by: Sandipan Das <address@hidden>
> [ use ISA300 define and abs() ]
> Signed-off-by: Nikunj A Dadhania <address@hidden>
> ---
>  target-ppc/helper.h     |  3 +++
>  target-ppc/int_helper.c | 23 +++++++++++++++++++++++
>  target-ppc/translate.c  | 15 ++++++++++++---
>  3 files changed, 38 insertions(+), 3 deletions(-)
> 
> diff --git a/target-ppc/helper.h b/target-ppc/helper.h
> index 68fd19e..ff6287e 100644
> --- a/target-ppc/helper.h
> +++ b/target-ppc/helper.h
> @@ -118,6 +118,9 @@ DEF_HELPER_3(vsubudm, void, avr, avr, avr)
>  DEF_HELPER_3(vavgub, void, avr, avr, avr)
>  DEF_HELPER_3(vavguh, void, avr, avr, avr)
>  DEF_HELPER_3(vavguw, void, avr, avr, avr)
> +DEF_HELPER_3(vabsdub, void, avr, avr, avr)
> +DEF_HELPER_3(vabsduh, void, avr, avr, avr)
> +DEF_HELPER_3(vabsduw, void, avr, avr, avr)
>  DEF_HELPER_3(vavgsb, void, avr, avr, avr)
>  DEF_HELPER_3(vavgsh, void, avr, avr, avr)
>  DEF_HELPER_3(vavgsw, void, avr, avr, avr)
> diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c
> index 15947ad..c1b341c 100644
> --- a/target-ppc/int_helper.c
> +++ b/target-ppc/int_helper.c
> @@ -629,6 +629,29 @@ VAVG(w, s32, int64_t, u32, uint64_t)
>  #undef VAVG_DO
>  #undef VAVG
>  
> +#define VABSDU_DO(name, element, etype)                                 \

You don't appear to actually use the type parameter.

> +void helper_v##name(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b)           \
> +{                                                                       \
> +    int i;                                                              \
> +                                                                        \
> +    for (i = 0; i < ARRAY_SIZE(r->element); i++) {                      \
> +        r->element[i] = abs(a->element[i] - b->element[i]);             \
> +    }                                                                   \
> +}
> +
> +/* VABSDU - Vector absolute difference unsigned
> + *   name    - instruction mnemonic suffix (b: byte, h: halfword, w: word)
> + *   element - element type to access from vector
> + *   etype   - internal data type to use for elements
> + */
> +#define VABSDU(type, element, etype)                                    \
> +    VABSDU_DO(absdu##type, element, etype)
> +VABSDU(b, u8, uint16_t)
> +VABSDU(h, u16, uint32_t)
> +VABSDU(w, u32, uint64_t)
> +#undef VABSDU_DO
> +#undef VABSDU
> +
>  #define VCF(suffix, cvt, element)                                       \
>      void helper_vcf##suffix(CPUPPCState *env, ppc_avr_t *r,             \
>                              ppc_avr_t *b, uint32_t uim)                 \
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index 23ef538..b18e13f 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -7373,8 +7373,17 @@ GEN_VXFORM(vminsh, 1, 13);
>  GEN_VXFORM(vminsw, 1, 14);
>  GEN_VXFORM(vminsd, 1, 15);
>  GEN_VXFORM(vavgub, 1, 16);
> +GEN_VXFORM(vabsdub, 1, 16);
> +GEN_VXFORM_DUAL(vavgub, PPC_ALTIVEC, PPC_NONE, \
> +                vabsdub, PPC_NONE, PPC2_ISA300)
>  GEN_VXFORM(vavguh, 1, 17);
> +GEN_VXFORM(vabsduh, 1, 17);
> +GEN_VXFORM_DUAL(vavguh, PPC_ALTIVEC, PPC_NONE, \
> +                vabsduh, PPC_NONE, PPC2_ISA300)
>  GEN_VXFORM(vavguw, 1, 18);
> +GEN_VXFORM(vabsduw, 1, 18);
> +GEN_VXFORM_DUAL(vavguw, PPC_ALTIVEC, PPC_NONE, \
> +                vabsduw, PPC_NONE, PPC2_ISA300)
>  GEN_VXFORM(vavgsb, 1, 20);
>  GEN_VXFORM(vavgsh, 1, 21);
>  GEN_VXFORM(vavgsw, 1, 22);
> @@ -10890,9 +10899,9 @@ GEN_VXFORM(vminsb, 1, 12),
>  GEN_VXFORM(vminsh, 1, 13),
>  GEN_VXFORM(vminsw, 1, 14),
>  GEN_VXFORM_207(vminsd, 1, 15),
> -GEN_VXFORM(vavgub, 1, 16),
> -GEN_VXFORM(vavguh, 1, 17),
> -GEN_VXFORM(vavguw, 1, 18),
> +GEN_VXFORM_DUAL(vavgub, vabsdub, 1, 16, PPC_ALTIVEC, PPC_NONE),
> +GEN_VXFORM_DUAL(vavguh, vabsduh, 1, 17, PPC_ALTIVEC, PPC_NONE),
> +GEN_VXFORM_DUAL(vavguw, vabsduw, 1, 18, PPC_ALTIVEC, PPC_NONE),
>  GEN_VXFORM(vavgsb, 1, 20),
>  GEN_VXFORM(vavgsh, 1, 21),
>  GEN_VXFORM(vavgsw, 1, 22),

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature