Re: [Qemu-ppc] [PATCH RFC v0 3/6] target-ppc: add vcmpnez[b, h, w][.] instructions

[Nikunj A Dadhania]

David Gibson <address@hidden> writes:

> [ Unknown signature status ]
> On Wed, Jul 27, 2016 at 12:56:55AM +0530, Nikunj A Dadhania wrote:
>> From: Swapnil Bokade <address@hidden>
>> 
>> Adds following instructions:
>> 
>> vcmpnezb[.]: Vector Compare Not Equal or Zero Byte
>> vcmpnezh[.]: Vector Compare Not Equal or Zero Halfword
>> vcmpnezw[.]: Vector Compare Not Equal or Zero Word
>> 
>> Signed-off-by: Swapnil Bokade <address@hidden>
>> Signed-off-by: Nikunj A Dadhania <address@hidden>
>> ---
>>  target-ppc/helper.h     |  6 ++++++
>>  target-ppc/int_helper.c | 49 
>> +++++++++++++++++++++++++++++++++++++++++++++++++
>>  target-ppc/translate.c  |  6 ++++++
>>  3 files changed, 61 insertions(+)
>> 
>> diff --git a/target-ppc/helper.h b/target-ppc/helper.h
>> index ff6287e..e93b84b 100644
>> --- a/target-ppc/helper.h
>> +++ b/target-ppc/helper.h
>> @@ -144,6 +144,9 @@ DEF_HELPER_4(vcmpequb, void, env, avr, avr, avr)
>>  DEF_HELPER_4(vcmpequh, void, env, avr, avr, avr)
>>  DEF_HELPER_4(vcmpequw, void, env, avr, avr, avr)
>>  DEF_HELPER_4(vcmpequd, void, env, avr, avr, avr)
>> +DEF_HELPER_4(vcmpnezb, void, env, avr, avr, avr)
>> +DEF_HELPER_4(vcmpnezh, void, env, avr, avr, avr)
>> +DEF_HELPER_4(vcmpnezw, void, env, avr, avr, avr)
>>  DEF_HELPER_4(vcmpgtub, void, env, avr, avr, avr)
>>  DEF_HELPER_4(vcmpgtuh, void, env, avr, avr, avr)
>>  DEF_HELPER_4(vcmpgtuw, void, env, avr, avr, avr)
>> @@ -160,6 +163,9 @@ DEF_HELPER_4(vcmpequb_dot, void, env, avr, avr, avr)
>>  DEF_HELPER_4(vcmpequh_dot, void, env, avr, avr, avr)
>>  DEF_HELPER_4(vcmpequw_dot, void, env, avr, avr, avr)
>>  DEF_HELPER_4(vcmpequd_dot, void, env, avr, avr, avr)
>> +DEF_HELPER_4(vcmpnezb_dot, void, env, avr, avr, avr)
>> +DEF_HELPER_4(vcmpnezh_dot, void, env, avr, avr, avr)
>> +DEF_HELPER_4(vcmpnezw_dot, void, env, avr, avr, avr)
>>  DEF_HELPER_4(vcmpgtub_dot, void, env, avr, avr, avr)
>>  DEF_HELPER_4(vcmpgtuh_dot, void, env, avr, avr, avr)
>>  DEF_HELPER_4(vcmpgtuw_dot, void, env, avr, avr, avr)
>> diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c
>> index c1b341c..bffe8d6 100644
>> --- a/target-ppc/int_helper.c
>> +++ b/target-ppc/int_helper.c
>> @@ -718,6 +718,55 @@ VCMP(gtsd, >, s64)
>>  #undef VCMP_DO
>>  #undef VCMP
>>  
>> +#define VCMPNEZ_DO(suffix, element, record)                         \
>> +void helper_vcmpnez##suffix(CPUPPCState *env, ppc_avr_t *r,         \
>> +                            ppc_avr_t *a, ppc_avr_t *b)                 \
>> +{                                                                       \
>> +    uint64_t ones = (uint64_t)-1;                                       \
>> +    uint64_t all = ones;                                                \
>> +    uint64_t none = 0;                                                  \
>> +    int i;                                                              \
>> +                                                                        \
>> +    for (i = 0; i < ARRAY_SIZE(r->element); i++) {                      \
>> +        uint64_t result = ((a->element[i] == 0)                         \
>> +                           || (b->element[i] == 0)                      \
>> +                           || (a->element[i] != b->element[i]) ?        \
>> +                           ones : 0x0);
>> \
>
> Couldn't you just use r->element[i] = result instead of the switch?

Yes, you are right.

>> +        switch (sizeof(a->element[0])) {                                \
>> +        case 8:                                                         \
>> +            r->u64[i] = result;                                         \
>> +            break;
>> \
>
> Also it doesn't actually look like there is a 64-bit case.

Right, will drop.

Regards
Nikunj