quilt-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Quilt-dev] Call for 0.42


From: Andreas Gruenbacher
Subject: Re: [Quilt-dev] Call for 0.42
Date: Sun, 24 Jul 2005 00:06:01 +0200
User-agent: KMail/1.7.1

On Saturday 23 July 2005 23:05, Jean Delvare wrote:
> Hi Andreas,
>
> [Andreas Gruenbacher]
>
> > Calling setlocale with a value that is possibly wrong doesn't appeal
> > to me.  I'd prefer this:
> >
> > BEGIN {
> >     if (eval { require Locale::gettext }) {
> >     import Locale::gettext;
> >     require POSIX;
> >     import POSIX, qw(setlocale LC_MESSAGES);
> >     } else {
>
> I am reluctant to explicitely importing LC_MESSAGES here, as perl 5.6.x
> doesn't know about it. We did not import it explicitely at first and it
> was working, so I don't see why it would now be needed. As a matter of
> fact, it works fine for me without it.

Yes, fine.

> So, here is my latest proposal:

Okay, it's still a bit long and ugly, but I think we can live with it. Maybe a 
comment why we are doing this hack would be useful, too.

Thanks,
-- 
Andreas Gruenbacher <address@hidden>
SUSE Labs, SUSE LINUX PRODUCTS GMBH




reply via email to

[Prev in Thread] Current Thread [Next in Thread]