Re: [Quilt-dev] [PATCH] Remember location of patches and series file

[Jean Delvare]

Le vendredi 11 décembre 2009 17:00, David Paleino a écrit :
> Jean Delvare wrote:
> 
> > Hi David,
> 
> Hi Jean,
> no need to CC me, thanks :)

My mailer did it, not me. And it will certainly do it again, as I
will never bother remembering who wants Cc and who doesn't.

> > Le vendredi 4 décembre 2009 15:19, David Paleino a écrit :
> >> If you only share $QUILT_PATCHES (modulo the exception above), you're not
> >> giving some additional information needed to apply the patches -- i.e.
> >> QUILT_PATCHES itself.
> > 
> > Here I'm totally lost, sorry. You share $QUILT_PATCHES but
> > QUILT_PATCHES is missing? Doh. Maybe try with a concrete example?
> 
> You have QUILT_PATCHES=./foo/ in .pc/quiltrc, and you share foo/.
> 
> Once you put foo/ under ./ in your source project, how does quilt know that 
> *that* is the real QUILT_PATCHES to look for? You can't, since that 
> information was in something you didn't share.
> 
> Hope that's clearer now?

OK, I see it now, thanks for clarifying.

However, I don't think that your scenario contradicts quilt's
documentation. When the documentation says that it is sufficient to
share the patches directory (including the series file), I believe it
means sharing the _contents_, not the location. That is, put the
patches directory in a tarball, e-mail it to someone, and that person
can setup his/her own source tree and apply the patch series. I do
not think that the documentation meant that the other person would
have his/her source tree automatically setup.

In my example, this means that the tarball in the e-mail doesn't get
automatically extracted to the right directory on the recipient's
system ;)

In your example, it means that the non-standard patches directory
name information must be provided to all users of the source
repository. This could be done by using .pc/quiltrc (as I think we
all agree that it is acceptable to have this one file under $VCS
even though the rest of the directory will never be), or a wrapper
to quilt, or simply documentation explaining how to set things up.

Anyway, enough with this. Let's focus on what functionality is
needed, implement it if it makes sense, and eventually update the
documentation if needed.

-- 
Jean Delvare
Suse L3