Re: [Quilt-dev] [PATCH] Remember location of patches and series file

[Jean Delvare]

Hi Martin,

Le dimanche 13 décembre 2009 01:49, Martin Panter a écrit :
> On 12/12/2009, Jean Delvare <address@hidden> wrote:
> >  Now I have a question. How does your setup differs from:
> >  * patches/ is a symbolic link to ../patches/
> >  * series is a symbolic link to ../patches/series-vad-2
> >
> >  The above can be implemented without any change to the current
> >  quilt code, and I don't see why it would fail. Am I missing
> >  something?
> 
> Symbolic links would do the job nicely here, but I'm actually using
> Quilt on "MSYS" (Windows), on a FAT32 filesystem, which doesn't do
> symbolic links. Maybe I should have pointed that out a long time ago.

Yes, you should have. So basically your problem is that you're using
the wrong filesystem/OS for the job. Rather that trying to change
quilt to workaround your environment insufficiencies, what about
switching to an environment suitable for your development tasks?

> > (...)
> > For now, I don't think anyone ever proposed to make the location of
> >  .pc configurable, so it would seem reasonable to use  it as the
> >  marker for the root of the source tree. That would be a change from
> >  the current situation (we look for the patches directory).
> 
> I have a patch that makes Quilt search for ".pc" in addition to
> "patches" and uses whichever one it finds first. This was necessary to
> stop Quilt finding my "../patches" after ignoring the higher-level
> ".pc" directory. Again I guess "quilt init" would help here by
> providing a method to create the ".pc" directory.

Not sure if "quilt init" alone would help. It would create ".pc", but
not your hypothetical custom quiltrc config file. And even after you
have created your configuration file, there's no way quilt will read
it before it has determined the root of the source tree, and in order
to do this properly, it needs the value of QUILT_PATCHES, which is
defined in that file. That won't work, obviously.

So your other patch to also use ".pc" to determine the root of the
source tree would also be needed.

> Hmm, this makes me think that Quilt would also get confused by
> "debian/patches" if you ever ran it inside the "debian" directory

Correct. And neither "quilt init" nor your proposed patch would solve
this one. The only way would be to look for ".pc" _instead of_
"patches" when looking for the root, but that would make "quilt init"
mandatory, which I am fairly certain we do not want.

I doubt this is a serious problem anyway. If you can't run quilt from
"debian/patches", just don't do it.

-- 
Jean Delvare
Suse L3