Re: [Quilt-dev] Quilt 0.60 is coming

[Jean Delvare]

On Friday 24 February 2012 12:32:28 am Raphael Hertzog wrote:
> On Thu, 23 Feb 2012, Jean Delvare wrote:
> > For example, ensure-manpage-has-correct-patches-dir works for you,
> > but it relies on quilt internals which aren't documented and could
> > change, so I am reluctant to take it as is.
> 
> quilt itself should be able to rely on quilt's internals, no?

It's questionable whether calling quilt from the Makefile qualifies as 
"internal". But I would admit that it's not really external either... 
it's somewhere in the middle.

My main concern is that passing QUILT_PC that way is not documented. 
Passing QUILT_PATCHES and QUILT_SERIES is documented in quilt(1) but 
passing QUILT_PC is not. I think we should document it first.

Then passing QUILT_PC=.fake_pc is kind of a hack, it works in practice 
[1] but doesn't look too good to my eyes at least. I am wondering if it 
would make sense to add a --dumb mode to quilt where it wouldn't look 
for .pc or series up to the filesystem root, but would just assume we 
are at the root of the project and trust the QUILT_* environment 
variables. This would be useful for generating the documentation, and 
there may be other use cases as well, for example nesting quilt trees. 
Opinions?

[1] It would fail if somewhere up the filesystem root exists a directory 
named .fake_pc with the relevant files in it... Highly unlikely, but not 
impossible.

-- 
Jean Delvare
Suse L3