quilt-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Quilt-dev] [patch 6/8] test/run: Declare global variables as such


From: Jean Delvare
Subject: [Quilt-dev] [patch 6/8] test/run: Declare global variables as such
Date: Sun, 02 Feb 2014 15:20:22 +0100
User-agent: quilt/0.61-1

Declare all global variables with qw() and stop passing them as
arguments to some functions.
---
 test/run |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

--- a/test/run
+++ b/test/run
@@ -49,22 +49,23 @@ use FileHandle;
 use Getopt::Std;
 use POSIX qw(isatty setuid getcwd);
 use Text::ParseWords;
-use vars qw($opt_l $opt_q $opt_v %output);
+use vars qw($opt_l $opt_q $opt_v %output $OK $FAILED $tests $failed);
 
 $opt_l = ~0;  # a really huge number
 getopts('l:qv');
 
-my ($OK, $FAILED) = ("ok", "failed");
+$OK = "ok";
+$FAILED = "failed";
 if (isatty(fileno(STDOUT))) {
        $OK = "\033[32m" . $OK . "\033[m";
        $FAILED = "\033[31m\033[1m" . $FAILED . "\033[m";
 }
+$tests = $failed = 0;
 
 my $prog;
 my ($in, $out) = ([], []);
 my $prog_line = 0;
 my $last_status = 0;
-my ($tests, $failed) = (0,0);
 my $lineno;
 my $width = ($ENV{COLUMNS} || 80) >> 1;
 my $origdir = getcwd;
@@ -97,9 +98,8 @@ sub print_footer($)
        }
 }
 
-sub flush_output($)
+sub flush_output()
 {
-       my $failed = shift;
        return unless $opt_q;
 
        print $output{header} || "",
@@ -315,5 +315,5 @@ if (isatty(fileno(STDOUT))) {
        }
 }
 print_footer "$status\n";
-flush_output $failed;
+flush_output;
 exit $failed ? 1 : 0;





reply via email to

[Prev in Thread] Current Thread [Next in Thread]