Re: [rdiff-backup-users] rdiff to SMB share?

[Ben Escoto]

>>>>> Cengiz Gunay <address@hidden>
>>>>> wrote the following on Wed, 11 Jan 2006 15:02:44 -0500 (EST)
> 
> > Sure, the sanity case was just supposed to check whether basic
> > characters were allowed.  I just checked in this simple patch: ...
> 
> Ok, I got the CVS version, and I upgraded to librsync 0.9.7. I got
> rdiff-backup to work within my ext3 filesystem. When I target the SMB
> filesystem, this time I got a different error. Any clues? The error
> follows and I have some final comments at the bottom:

Ahh, if you checked out CVS, you got the development version, and will
get entirely different errors. :-)  

> Exception 'local variable 'ext_rp' referenced before assignment' raised of 
...
>     assert not ext_rp.lstat()

Looks like a silly mistake that just got added.  Update your CVS or
apply:

--- fs_abilities.py     10 Jan 2006 22:28:15 -0000      1.27
+++ fs_abilities.py     11 Jan 2006 21:22:25 -0000
@@ -201,11 +201,12 @@
 
                # Try a UTF-8 encoded character
                extended_filename = ':\\ ' + chr(225) + chr(132) + chr(137)
+               ext_rp = None
                try:
                        ext_rp = subdir.append(extended_filename)
                        ext_rp.touch()
                except (IOError, OSError):
-                       assert not ext_rp.lstat()
+                       if ext_rp: assert not ext_rp.lstat()
                        self.extended_filenames = 0
                else:
                        assert ext_rp.lstat()


-- 
Ben Escoto

pgpyQm8iAutC1.pgp
Description: PGP signature