savannah-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [savannah-help-public] Wrong encoding in commit messages sent to gro


From: Bob Proulx
Subject: Re: [savannah-help-public] Wrong encoding in commit messages sent to groff-commit
Date: Sun, 16 Feb 2014 15:37:50 -0700
User-agent: Mutt/1.5.21 (2010-09-15)

Werner LEMBERG wrote:
> > In the meantime I will change the config to this one.  I think that
> > will prevent the sending of the branch change notification but will
> > still preserve the individual commit notifications.
> >
> >    mailinglist =
> >    commitList = address@hidden
> 
> This works, thanks.  However, there are some issues.  After a commit,
> mails are sent twice to `groff-commit':
>
>   Subject: [Groff-commit] [groff] 01/01: * tmac/groff_mdoc.man: \
>              Improve the manual page template.
>   From: Werner LEMBERG <address@hidden>
>   To: address@hidden
>   Date: Sun, 16 Feb 2014 07:28:09 +0000
>   Sender: address@hidden
>   Reply-To: Ingo Schwarze <address@hidden>

Note: Sender: address@hidden
I think that is the second extra one.

>   Subject: [Groff-commit] [groff] 01/01: * tmac/groff_mdoc.man: \
>              Improve the manual page template.
>   From: Werner LEMBERG <address@hidden>
>   To: address@hidden
>   Date: Sun, 16 Feb 2014 07:28:09 +0000
>   Sender: address@hidden
>   Reply-To: Ingo Schwarze <address@hidden>

Note: Sender: address@hidden
I think that is the normal one generated on vcs.

The mailing list only records one message sent for that commit.

  http://lists.gnu.org/archive/html/groff-commit/2014-02/threads.html

I think that for any regular subscriber they would have only gotten
one copy of the message.  I think you are special.  :-) I can only
imagine that there is an alias somewhere for groff-commit that is
coming to you directly and that is why you have received a second one.
I looked but could not find an alias anywhere however.  Not sure why
you are getting a second copy.

Could you forward two messages with all of the Received headers intact
so that we could trace through the mail relays and see where it came
through?

> Additionally, the `Reply-To' field is set to the author of the patch.
> However, I would prefer if it was set to address@hidden', too.

The Mail-Followup-To: address@hidden header is insufficient?

But okay.  Have adjusted the configuration so that the reply-to is set
to address@hidden  Since groff-commit isn't a discussion list.

Since I was looking and touching things I gratuitiously removed the
duplicated subject tag.  Personally I don't like subject tags at all,
filing should be done with List-id:, and seeing 22 characters consumed
from the subject that way was just too much.

> Finally, while doing `git push', I see
> 
>   remote: *** no recipients configured so no email will be sent
>   remote: *** for 'refs/heads/master' update \
>     c82e9a5ae45ca06ea95fa22b0f7fd37ad0e64be6->6d9c6728213e047bccd622bfb0

Hmm...  That does seem egregious since the committer has no control
over this configuration.  Maybe setting it to "nobody" would be kinder
since then it would see a recipient and would avoid that message.
Except that for some reason on Savannah the nobody user forwards to
root.  And the alias list seems to be automatically generated by a
process that I am not yet aware of.  I will put that on the list to
investigate.

In the meantime I have hacked the git_multimail.py script to avoid
that message.  I agree that it isn't nice to send that to the
committer.

> None of those glitches are serious, but I want to report them
> anyway :-) Maybe you want to forward them to the multimailhook people.

Unfortunately I lack the time to take on an additional project at this
point.  I am still learning Savannah.  I will just make a local
modification to avoid the spurious commit warning message about no
recipients.  But if you or someone else wished to request new features
of the upstream that would be great.

  https://github.com/mhagger/git-multimail

Bob



reply via email to

[Prev in Thread] Current Thread [Next in Thread]