Re: new module 'iswblank'

[Eric Blake]

On 02/06/2011 02:06 PM, Bruno Haible wrote:
> The module 'wctype-h' causes an object file (iswblank.o) to be built on
> some platforms. It's better to separate code modules from header file
> modules.
> 
> Here's the proposed change.
> 
> 
> 2011-02-06  Bruno Haible  <address@hidden>
> 
>       New module 'iswblank'.
>       * lib/wctype.in.h (iswblank): Don't declare of GNULIB_ISWBLANK is 0.

s/of/if/

> int
> main (void)
> {
>   /* Check that the function exist as a function or as a macro.  */
>   (void) iswblank (0);

Isn't this line technically redundant...

>   /* Check that the isw* functions map WEOF to 0.  */
>   ASSERT (!iswblank (e));

with this?

> +++ NEWS      Sun Feb  6 20:41:59 2011
> @@ -12,6 +12,10 @@
>  
>  Date        Modules         Changes
>  
> +2011-02-06  wctype          This module no longer provides the iswblank()
> +                            function. If you need this function, you now need
> +                            to request the 'iswblank' module.
> +
>  2011-02-06  wctype          This module is renamed to wctype-h.

This is confusing to list wctype twice for the same date; would a single
entry look better?

2011-02-06  wctype   This module has been split.  The <wctype.h>
                     header is now provided by the 'wctype-h', and
                     the iswblank() function is now provided by
                     the'iswblank' module, leaving just the wctype()
                     function in this module.

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature