Re: new module 'iswblank'

[Bruno Haible]

Eric Blake wrote:
> >     * lib/wctype.in.h (iswblank): Don't declare of GNULIB_ISWBLANK is 0.
> 
> s/of/if/

Oops, corrected.

> >   /* Check that the function exist as a function or as a macro.  */
> >   (void) iswblank (0);
> 
> Isn't this line technically redundant...
> 
> >   /* Check that the isw* functions map WEOF to 0.  */
> >   ASSERT (!iswblank (e));
> 
> with this?

Technically yes, it is redundant. But it doesn't hurt, and it's consistent
with test-wctype-h.c

> > +2011-02-06  wctype          This module no longer provides the iswblank()
> > +                            function. If you need this function, you now 
> > need
> > +                            to request the 'iswblank' module.
> > +
> >  2011-02-06  wctype          This module is renamed to wctype-h.
> 
> This is confusing to list wctype twice for the same date; would a single
> entry look better?
> 
> 2011-02-06  wctype   This module has been split.  The <wctype.h>
>                      header is now provided by the 'wctype-h', and
>                      the iswblank() function is now provided by
>                      the'iswblank' module, leaving just the wctype()
>                      function in this module.

This is confusing too: the reader may think that the 'wctype-h' module
does not define any functions any more. But it defines iswalnum, ..., towupper.

It may be less confusing if I add make the dates different :-) I'll push
'wctype' today and 'iswblank' tomorrow.

Bruno
-- 
In memoriam Hatun Sürücü <http://en.wikipedia.org/wiki/Hatun_Sürücü>