Re: NSPopUpButton*, NSMenu* patch.

[Nicola Pero]

Hi Fred

> I just had a look at your patch and failed to understand how with the 
> new code you suggest for NSApplication the name of a window could be 
> changed and correctly displayed in the windows menu.

Thanks!  You're right - my fault in applying the patch without thinking
enough - I had overlooked that.

Anyway, I've fixed it on CVS to only exit the method if the actual menu
item title didn't change; I added extensive comments so hopefully the next
maintainer having to patch that code in a hurry won't fall into the same
trick.

Since I was there, I also fixed a bug for windows which had a title, but
then get converted to having no title.  The old code wouldn't remove the
old menu item. (I didn't test this though).

#

About the menu code, yes I agree with you that we need to be careful in
trying to apply only patches which clearly improve on the existing code.

We need to try raise the quality level of the changes we do to NSMenu*.